GeneralBots/generalbots
1
0
Fork 0
Code Activity Actions 5

fix: use continue instead of break on low-relevance KB search results
All checks were successful
BotServer CI/CD / build (push) Successful in 4m9s
Details

Browse source 
Bug: Using break instead of continue when encountering low-relevance
results caused the search to stop prematurely, missing potentially
relevant chunks in subsequent results.

- Changed break to continue when score < 0.4 in search_single_collection
- Changed break to continue when score < 0.4 in search_single_kb
- Lowered threshold from 0.5 to 0.4 for consistency

This ensures all search results are evaluated, not just those before
the first low-relevance result.
This commit is contained in:
Rodrigo Rodriguez (Pragmatismo) 2026-04-15 10:19:13 -03:00
parent dd15899ac3
commit 5338ffab12
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/core/bot/kb_context.rs
View file

@ -343,10 +343,10 @@ impl KbContextManager {
total_tokens += tokens; total_tokens += tokens;
if result.score < 0.4 { if result.score < 0.4 {
debug!("Skipping low-relevance result (score: {})", result.score); debug!("Skipping low-relevance result (score: {})", result.score);
break; continue;
} }
} }
Ok(KbContext { Ok(KbContext {
@ -409,9 +409,9 @@ impl KbContextManager {
total_tokens += tokens; total_tokens += tokens;
if result.score < 0.5 { if result.score < 0.4 {
debug!("Skipping low-relevance result (score: {})", result.score); debug!("Skipping low-relevance result (score: {})", result.score);
break; continue;
} }
} }