GeneralBots/generalbots
1
0
Fork 0
Code Activity Actions 5

Fix: nested runtime panic in AuthConfig::from_env()
Some checks failed
BotServer CI/CD / build (push) Failing after 1s
Details

Browse source 
Root cause: AuthConfig::from_env() was creating a new tokio runtime
with Runtime::new() inside an existing runtime during initialization.

Impact: Botserver crashed with "Cannot start a runtime from within a
runtime" panic right after CORS layer initialization.

Fix: Use new_current_thread() + std:🧵:spawn pattern (same as
get_database_url_sync fix) to create an isolated thread for async operations.

Files: src/security/auth_api/config.rs

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
Rodrigo Rodriguez (Pragmatismo) 2026-04-03 14:02:08 -03:00
parent 61642343a8
commit f097f000d8
1 changed files with 29 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
src/security/auth_api/config.rs
View file

@ -1,3 +1,5 @@
use anyhow::anyhow;
#[derive(Debug, Clone)] #[derive(Debug, Clone)]
pub struct AuthConfig { pub struct AuthConfig {
pub require_auth: bool, pub require_auth: bool,
@ -54,26 +56,33 @@ impl AuthConfig {
if let Ok(secret) = std::env::var("VAULT_TOKEN") { if let Ok(secret) = std::env::var("VAULT_TOKEN") {
if !secret.is_empty() { if !secret.is_empty() {
let rt = tokio::runtime::Runtime::new().ok(); let sm = crate::core::shared::utils::get_secrets_manager_sync();
if let Some(rt) = rt { if let Some(sm) = sm {
let sm = crate::core::shared::utils::get_secrets_manager_sync(); let sm_clone = sm.clone();
if let Some(sm) = sm { let (tx, rx) = std::sync::mpsc::channel();
if let Ok(secrets) = std::thread::spawn(move || {
rt.block_on(sm.get_secret(crate::core::secrets::SecretPaths::JWT)) let rt = tokio::runtime::Builder::new_current_thread()
{ .enable_all()
if let Some(s) = secrets.get("secret") { .build();
config.jwt_secret = Some(s.clone()); let result = match rt {
} Ok(rt) => rt.block_on(sm_clone.get_secret(crate::core::secrets::SecretPaths::JWT)),
if let Some(r) = secrets.get("require_auth") { Err(e) => Err(anyhow::anyhow!("Failed to create runtime: {}", e)),
config.require_auth = r == "true" || r == "1"; };
} let _ = tx.send(result);
if let Some(p) = secrets.get("anonymous_paths") { });
config.allow_anonymous_paths = p if let Ok(Ok(secrets)) = rx.recv() {
.split(',') if let Some(s) = secrets.get("secret") {
.map(|s| s.trim().to_string()) config.jwt_secret = Some(s.clone());
.filter(|s| !s.is_empty()) }
.collect(); if let Some(r) = secrets.get("require_auth") {
} config.require_auth = r == "true" || r == "1";
}
if let Some(p) = secrets.get("anonymous_paths") {
config.allow_anonymous_paths = p
.split(',')
.map(|s| s.trim().to_string())
.filter(|s| !s.is_empty())
.collect();
} }
} }
} }